From ed8f3ab02e43352f22983fc6d3a00fa84cc00101 Mon Sep 17 00:00:00 2001
From: Raymond LaRose <rlarose@cityofnorwich.org>
Date: Tue, 27 May 2025 13:23:37 -0400
Subject: [PATCH] Update pester tests

---
 PS-GiteaUtilities/PS-GiteaUtilities.psm1 |  8 +++++---
 Tests/Invoke-GiteaFileDownload.Tests.ps1 | 18 ++++++++----------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/PS-GiteaUtilities/PS-GiteaUtilities.psm1 b/PS-GiteaUtilities/PS-GiteaUtilities.psm1
index 4ff1291..f4cb4d2 100644
--- a/PS-GiteaUtilities/PS-GiteaUtilities.psm1
+++ b/PS-GiteaUtilities/PS-GiteaUtilities.psm1
@@ -434,8 +434,8 @@ Function Invoke-GiteaFileDownload {
             return [PSCustomObject]@{
                 SourceURL = $downloadURL
                 Type = $type
-                Result = 'Success'
-                Error = "Skipped - item is a directory"
+                Result = 'Skipped'
+                Error = $null
                 Timestamp = Get-Date
                 FileSize = $null
             }
@@ -521,7 +521,7 @@ Function Invoke-GiteaFileDownload {
             Path = $fileOutputPath
             SourceURL = $downloadURL
             Type = "file"
-            Result = 'Failure'
+            Result = $null
             Error = $null
             Timestamp = Get-Date
             FileSize = $null
@@ -545,6 +545,7 @@ Function Invoke-GiteaFileDownload {
                 }
             }
             else {
+                $result.Result = 'Skipped'
                 $errorMsg = "The file '$fileOutputPath' already exists. Use the -Force switch to overwrite the file."
                 Write-Error $errorMsg
                 $result.Error = $errorMsg
@@ -578,6 +579,7 @@ Function Invoke-GiteaFileDownload {
             return $result
         }
         catch {
+            $result.Result = 'Failure'
             $errorMsg = "Failed to download file from Gitea: $_"
             Write-Error $errorMsg
             $result.Error = $errorMsg
diff --git a/Tests/Invoke-GiteaFileDownload.Tests.ps1 b/Tests/Invoke-GiteaFileDownload.Tests.ps1
index 0b19eb9..60446de 100644
--- a/Tests/Invoke-GiteaFileDownload.Tests.ps1
+++ b/Tests/Invoke-GiteaFileDownload.Tests.ps1
@@ -49,7 +49,7 @@ Describe 'Invoke-GiteaFileDownload' {
             $result = Invoke-GiteaFileDownload -downloadURL 'https://gitea.example.com/raw/path/to/file.txt' -token 'abc123'
 
             $result | Should -Not -BeNullOrEmpty
-            $result.Success | Should -Be $true
+            $result.Result | Should -Be 'Success'
             $result.Path | Should -Match 'file\.txt$'
         }
     }
@@ -60,7 +60,7 @@ Describe 'Invoke-GiteaFileDownload' {
             -outputPath 'docs/manual/' -token 'abc123'
 
             $result.Path | Should -Match 'docs[\\/]+manual[\\/]+file\.txt$'
-            $result.Success | Should -Be $true
+            $result.Result | Should -Be 'Success'
         }
     }
 
@@ -70,7 +70,7 @@ Describe 'Invoke-GiteaFileDownload' {
             -outputName 'newfile.txt' -token 'abc123'
 
             $result.Path | Should -Match 'newfile\.txt$'
-            $result.Success | Should -Be $true
+            $result.Result | Should -Be 'Success'
         }
     }
 
@@ -80,7 +80,7 @@ Describe 'Invoke-GiteaFileDownload' {
             -outputPath 'docs/manual/' -outputName 'newfile.txt' -token 'abc123'
 
             $result.Path | Should -Match 'docs[\\/]+manual[\\/]+newfile\.txt$'
-            $result.Success | Should -Be $true
+            $result.Result | Should -Be 'Success'
         }
     }
 
@@ -90,7 +90,7 @@ Describe 'Invoke-GiteaFileDownload' {
             -PreserveRelativePath -token 'abc123'
 
             $result.Path | Should -Match 'path[\\/]+to[\\/]+file\.txt$'
-            $result.Success | Should -Be $true
+            $result.Result | Should -Be 'Success'
         }
     }
 
@@ -98,8 +98,7 @@ Describe 'Invoke-GiteaFileDownload' {
         It 'Should skip items with type = dir' {
             $result = Invoke-GiteaFileDownload -outputPath 'docs/' -type 'dir' -token 'abc123'
 
-            $result.Success | Should -Be $true
-            $result.Error | Should -Match 'Skipped'
+            $result.Result | Should -Be 'Skipped'
         }
     }
 
@@ -116,8 +115,7 @@ Describe 'Invoke-GiteaFileDownload' {
         It 'Should not overwrite existing file without Force' {
             $result = Invoke-GiteaFileDownload -downloadURL 'https://gitea.example.com/raw/path/to/existingfile.txt' -token 'abc123'
 
-            $result.Success | Should -Be $false
-            $result.Error | Should -Match 'already exists'
+            $result.Result | Should -Be 'Skipped'
         }
     }
 
@@ -145,7 +143,7 @@ Describe 'Invoke-GiteaFileDownload' {
         It 'Should capture error and mark download as failed' {
             $result = Invoke-GiteaFileDownload -downloadURL 'https://gitea.example.com/raw/path/to/badfile.txt' -token 'abc123'
     
-            $result.Success | Should -Be $false
+            $result.Result | Should -Be 'Failure'
             $result.Error | Should -Match 'Failed to download'
         }
     }